Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS-1116 add logging and pip compile #11

Merged
merged 13 commits into from
Jul 6, 2022
Merged

FS-1116 add logging and pip compile #11

merged 13 commits into from
Jul 6, 2022

Conversation

harryyo
Copy link
Contributor

@harryyo harryyo commented Jul 4, 2022 •
edited
Loading

Add Logging, Gunicorn and Pip Compile

  • fsd_utils logging added
  • gunicorn run support added
  • Talisman security config streamlined
  • Some tests simplified to work with upgraded Werkzeug
  • Requirements streamlined with pip-compile

@harryyo harryyo temporarily deployed to Dev July 4, 2022 17:12 Inactive
@harryyo harryyo temporarily deployed to Dev July 4, 2022 17:13 Inactive
@harryyo harryyo temporarily deployed to Dev July 4, 2022 17:43 Inactive
@harryyo harryyo temporarily deployed to Dev July 4, 2022 17:44 Inactive
@harryyo harryyo temporarily deployed to Dev July 4, 2022 17:48 Inactive
@harryyo harryyo temporarily deployed to test July 4, 2022 17:51 Inactive
@harryyo harryyo temporarily deployed to test July 4, 2022 17:54 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 4, 2022 21:05 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 4, 2022 21:06 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 4, 2022 21:09 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to test July 4, 2022 21:12 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to test July 4, 2022 21:15 Inactive
Adam-W1
Adam-W1 reviewed Jul 5, 2022
View reviewed changes
app/create_app.py Outdated Show resolved Hide resolved
sentienthouseplant
sentienthouseplant suggested changes Jul 5, 2022
View reviewed changes
manifest.yml Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
Adam-W1
Adam-W1 requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@Adam-W1 Adam-W1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple comments :)

@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 5, 2022 16:06 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 5, 2022 16:06 Inactive
@ramsharma-prog ramsharma-prog temporarily deployed to Dev July 5, 2022 16:10 Inactive
@harryyo harryyo temporarily deployed to Dev July 5, 2022 16:10 Inactive
@harryyo harryyo temporarily deployed to Dev July 5, 2022 16:11 Inactive
@harryyo harryyo temporarily deployed to Dev July 5, 2022 16:15 Inactive
@harryyo harryyo temporarily deployed to test July 5, 2022 16:17 Inactive
@harryyo harryyo temporarily deployed to test July 5, 2022 16:20 Inactive
srh-sloan
srh-sloan reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@srh-sloan srh-sloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment from me, otherwise good to go!

config/__init__.py Show resolved Hide resolved
@harryyo harryyo temporarily deployed to Dev July 6, 2022 08:15 Inactive
@harryyo harryyo temporarily deployed to Dev July 6, 2022 08:16 Inactive
@harryyo harryyo temporarily deployed to Dev July 6, 2022 08:20 Inactive
srh-sloan
srh-sloan approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@srh-sloan srh-sloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@harryyo harryyo temporarily deployed to test July 6, 2022 08:22 Inactive
@harryyo harryyo temporarily deployed to test July 6, 2022 08:26 Inactive
@harryyo harryyo merged commit 703a2eb into main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-W1 Adam-W1 Adam-W1 approved these changes

@srh-sloan srh-sloan srh-sloan approved these changes

@ramsharma-prog ramsharma-prog Awaiting requested review from ramsharma-prog

@gidsg gidsg Awaiting requested review from gidsg

@gio-karunakaran gio-karunakaran Awaiting requested review from gio-karunakaran

@sentienthouseplant sentienthouseplant Awaiting requested review from sentienthouseplant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harryyo @srh-sloan @sentienthouseplant @ramsharma-prog @Adam-W1