Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Increase minimum required CMake version to 3.16.3 #1208

Merged
merged 1 commit into from
May 31, 2024

Conversation

dzenanz
Copy link
Contributor

@dzenanz dzenanz commented May 30, 2024

Avoids configure errors with the latest ITK and CMake 3.29.3:

6>CMake Warning (dev) at M:/a/Srd/ITK-build/ITKConfig.cmake:90 (if):
6>  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
6>  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
6>  set the policy and suppress this warning.
6>
6>  IN_LIST will be interpreted as an operator when the policy is set to NEW.
6>  Since the policy is not set the OLD behavior will be used.
6>Call Stack (most recent call first):
6>  Libs/ImageProcessing/ITK/Core/CMakeLists.txt:16 (find_package)
6>This warning is for project developers.  Use -Wno-dev to suppress it.
6>
6>CMake Error at M:/a/Srd/ITK-build/ITKConfig.cmake:90 (if):
6>  if given arguments:
6>
6>    "ITK_FIND_REQUIRED_ITKCommon" "OR" "M" "IN_LIST" "ITK_MODULES_ENABLED"
6>
6>  Unknown arguments specified
6>Call Stack (most recent call first):
6>  Libs/ImageProcessing/ITK/Core/CMakeLists.txt:16 (find_package)
6>
6>
6>-- Configuring incomplete, errors occurred!

Avoids configure errors with the latest ITK and CMake 3.29.3:

6>CMake Warning (dev) at M:/a/Srd/ITK-build/ITKConfig.cmake:90 (if):
6>  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
6>  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
6>  set the policy and suppress this warning.
6>
6>  IN_LIST will be interpreted as an operator when the policy is set to NEW.
6>  Since the policy is not set the OLD behavior will be used.
6>Call Stack (most recent call first):
6>  Libs/ImageProcessing/ITK/Core/CMakeLists.txt:16 (find_package)
6>This warning is for project developers.  Use -Wno-dev to suppress it.
6>
6>CMake Error at M:/a/Srd/ITK-build/ITKConfig.cmake:90 (if):
6>  if given arguments:
6>
6>    "ITK_FIND_REQUIRED_ITKCommon" "OR" "M" "IN_LIST" "ITK_MODULES_ENABLED"
6>
6>  Unknown arguments specified
6>Call Stack (most recent call first):
6>  Libs/ImageProcessing/ITK/Core/CMakeLists.txt:16 (find_package)
6>
6>
6>-- Configuring incomplete, errors occurred!
@dzenanz
Copy link
Contributor Author

dzenanz commented May 31, 2024

@pieper @lassoan can someone review/merge this PR?

@jamesobutler jamesobutler enabled auto-merge (rebase) May 31, 2024 20:58
@jamesobutler jamesobutler merged commit e081be7 into commontk:master May 31, 2024
6 checks passed
@dzenanz
Copy link
Contributor Author

dzenanz commented Jun 1, 2024

Thanks James!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants