Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align fact package with conventions #35

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

Kyle9410-Chen
Copy link
Contributor

Type of changes

refactor

Purpose

  • Return entity instead of dto in fact service
  • Return ResponseEntity<Object> instead of Object in fact controller

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JAVA checkstyle 2 0 2.84s
✅ REPOSITORY dustilock yes no 0.02s
✅ REPOSITORY gitleaks yes no 1.12s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.87s
✅ REPOSITORY secretlint yes no 1.47s
✅ REPOSITORY syft yes no 1.52s
✅ REPOSITORY trivy-sbom yes no 0.13s
✅ REPOSITORY trufflehog yes no 3.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@YukinaMochizuki YukinaMochizuki merged commit acaf2fb into main Dec 26, 2024
3 checks passed
@YukinaMochizuki YukinaMochizuki deleted the refactor/align-fact-package-with-conventions branch December 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants