-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openpilot webcam support fixed #34215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
MikeBusuttil
commented
Dec 12, 2024
I'm unable to test this claim from the README. Does anyone have a PC they can hook up to a car to verify? |
MikeBusuttil
changed the title
Openpilot webcam support fixed
Openpilot webcam support improved
Dec 12, 2024
MikeBusuttil
commented
Dec 12, 2024
Co-authored-by: Adeeb Shihadeh <[email protected]>
Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Adeeb Shihadeh <[email protected]>
MikeBusuttil
changed the title
Openpilot webcam support improved
Openpilot webcam support fixed
Dec 31, 2024
elkoled
pushed a commit
to elkoled/openpilot
that referenced
this pull request
Dec 31, 2024
* control webcam with ENV vars * WIP: actual instructions * wording * file no longer exists * this is expected behavior, just untested * more readable * tested on fresh install * wording tweaks * explicit USE_WEBCAM toggle required Co-authored-by: Adeeb Shihadeh <[email protected]> * debug-ability improved Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Adeeb Shihadeh <[email protected]> * newline removed --------- Co-authored-by: Adeeb Shihadeh <[email protected]>
elkoled
pushed a commit
to elkoled/openpilot
that referenced
this pull request
Jan 4, 2025
* control webcam with ENV vars * WIP: actual instructions * wording * file no longer exists * this is expected behavior, just untested * more readable * tested on fresh install * wording tweaks * explicit USE_WEBCAM toggle required Co-authored-by: Adeeb Shihadeh <[email protected]> * debug-ability improved Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Adeeb Shihadeh <[email protected]> * newline removed --------- Co-authored-by: Adeeb Shihadeh <[email protected]>
calvinpark
pushed a commit
to calvinpark/openpilot
that referenced
this pull request
Jan 8, 2025
…ew` (commaai#533) * cabana: enhance message heatmap visualization (commaai#34239) * enhance message heatmap visualization * TODO * improve log_factor * typo * bit_flip_counts * Openpilot webcam support improved (commaai#34215) * control webcam with ENV vars * WIP: actual instructions * wording * file no longer exists * this is expected behavior, just untested * more readable * tested on fresh install * wording tweaks * explicit USE_WEBCAM toggle required Co-authored-by: Adeeb Shihadeh <[email protected]> * debug-ability improved Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Adeeb Shihadeh <[email protected]> * newline removed --------- Co-authored-by: Adeeb Shihadeh <[email protected]> * Update metadrive wheel (commaai#34292) * test * new wheel * fix IR power scaling (commaai#34293) * fix IR power scaling * Update system/hardware/tici/hardware.h * replay: Update video immediately after seek when paused. (commaai#34237) replay: Update video immediately after seeking when paused. Otherwise, if paused then have to resume playback for the video frame to update and show the new location. Implemented by temporarily un-pausing replay for a single frame time. * cabana: add live and time-window heatmap modes for enhanced signal analysis (commaai#34296) add live and time-window heatmap modes * timed: diff against absolute value of timedelta (commaai#34299) * cabana: miscellaneous bug fixes and enhancements (commaai#34297) * toHexString * use QToolBar * fix incorrect groove rect * limit CAN_MAX_DATA_BYTES * add series type selector to chart toolbar * dim inactive messages * rename * add help to chart * cleanup * cabana: real-time cursor and video frame sync for chart and video (commaai#34301) * sync cursor and thumbnail between chart and video * Revert "replay: Update video immediately after seek when paused. (commaai#34237)" This reverts commit 3363881. * use thumbnails while scrubing * draw alert * no update on resume * draw timestamp * cleanup * replay: fix various synchronization and event handling issues (commaai#34254) fix various synchronization and event handling issues * cabana: fix crash in live streaming mode by skipping thumbnail display (commaai#34302) resolve crash in live streaming mode * bump panda * [bot] Update Python packages (commaai#34304) Update Python packages Co-authored-by: Vehicle Researcher <[email protected]> * cleanup touch_replay (commaai#34305) mathematics * uv from brew doesn't have self update * Skip registration on newer devices (commaai#34316) * tici: fix cpp device type (commaai#34315) fix cpp * Tinygrad upstream master (commaai#34325) Upstream master * [bot] Update Python packages (commaai#34320) Update Python packages Co-authored-by: Vehicle Researcher <[email protected]> * cabana: fix missing transmitter after undoing DBC message removal (commaai#34329) fix missing transmitter after undoing DBC message removal * Quick GC pass heading into 2025 (commaai#34330) * first pass * bye bye snpe * [bot] Update Python packages (commaai#34334) Update Python packages Co-authored-by: Vehicle Researcher <[email protected]> * Notre Dame model in tinygrad (commaai#34324) * release model: 6f23a03f-486b-4d3e-a314-19d149644c7c/700 * old style model in tinygrad * fix desire * tg hack * 20Hz * no gas probs * No gas here * better indexing --------- Co-authored-by: Yassine Yousfi <[email protected]> --------- Co-authored-by: Dean Lee <[email protected]> Co-authored-by: Mike Busuttil <[email protected]> Co-authored-by: Adeeb Shihadeh <[email protected]> Co-authored-by: Maxime Desroches <[email protected]> Co-authored-by: Angus Gratton <[email protected]> Co-authored-by: commaci-public <[email protected]> Co-authored-by: Vehicle Researcher <[email protected]> Co-authored-by: Harald Schäfer <[email protected]> Co-authored-by: Yassine Yousfi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USE_WEBCAM
toggle fixedThanks to @jyoung8607 for all the help getting this going