delete devcontainer #34181
Merged
delete devcontainer #34181
+1
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devcontainer seems to cause more problems than running natively on some platforms (macOS) + it has been deactivated in CI for over 3 months now.
For now, we should focus on reducing openpilot's dependencies and fixing the native experience when we can (for example this PR for macOS #34097).
We could always bring this back in the future if someone is willing to spend time making this super good.
This deletion was discussed twice on discord. The first time, no one said they used it. The second time, only on guy was using it sometimes.