Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: fix UI highlight for inactive items and crash in saveHeaderState() on closeEvent #34135

Merged

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Dec 1, 2024

  1. Resolve the crash occurring in messages_widget->saveHeaderState() during the closeEvent.
  2. Adjust the highlight color for inactive items to enhance visibility and differentiation.

@github-actions github-actions bot added the tools label Dec 1, 2024
@adeebshihadeh adeebshihadeh merged commit e02a6e0 into commaai:master Dec 2, 2024
18 checks passed
@deanlee deanlee deleted the cabana_fix_bugs_in_messageswidget branch December 3, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants