Optimize CI setup to <20s #34123
Closed
Optimize CI setup to <20s #34123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to commaai#30706 Optimize the `setup-with-retry` stage in CI jobs to finish in less than 20 seconds. * **Dockerfile.openpilot_base** - Split the installation of Python dependencies into smaller layers to improve download concurrency. - Add comments to explain the changes made. * **.github/workflows/setup-with-retry/action.yaml** - Reduce the sleep time between retries to 5 seconds. - Add a step to cache Python dependencies using GitHub Actions cache. * **.github/workflows/setup/action.yaml** - Add a step to restore the Python dependencies cache. - Add a step to save the Python dependencies cache.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
|
Looks like this is still a WIP? First one I checked is >1m |
Comment on lines
41
to
42
| path: ~/.cache/pip | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} |
There was a problem hiding this comment.
This caching approach won't work with our python setup.
* **Setup containerd and lazy loading:** - Add steps to set up containerd using `ghaction-setup-containerd` in `setup-with-retry/action.yaml` and `setup/action.yaml` - Add steps to use lazy loading with eStargz in `setup-with-retry/action.yaml` and `setup/action.yaml` * **Parallelize CI jobs:** - Add steps to run `setup-with-retry` and build openpilot in parallel in `compile-openpilot/action.yaml` and `selfdrive_tests.yaml`
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30706
Optimize the
setup-with-retrystage in CI jobs to finish in less than 20 seconds.Dockerfile.openpilot_base
.github/workflows/setup-with-retry/action.yaml
.github/workflows/setup/action.yaml