Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Debug Bridge Toggle #34092

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

amoghmunikote
Copy link

@amoghmunikote amoghmunikote commented Nov 23, 2024

This PR is for #34041 (just a milestone for the bounty).

Current list of things required for bounty

  • Add toggle into developer menu
  • Make toggle persistent
  • Enable it during setup
  • Add ADB over USB
  • Test ADB over USB
  • Make ADB over USB work properly
  • Cleanup code and condense it

For the sake of a concise recap, does the bounty require ADB to work over USB?

@amoghmunikote amoghmunikote marked this pull request as ready for review November 23, 2024 04:09
@amoghmunikote
Copy link
Author

Sorry, I did not mean to mark it ready for review. Please revert it to the original state.

Copy link
Contributor

github-actions bot commented Nov 23, 2024

UI Preview

settings_developer : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@maxime-desroches maxime-desroches marked this pull request as draft November 23, 2024 04:19
@adeebshihadeh
Copy link
Contributor

For the sake of a concise recap, does the bounty require ADB to work over USB?

Yes, that's the whole point. This also requires an accompanying agnos-builder PR to make it all work like SSH.

@amoghmunikote
Copy link
Author

Ok, I am just checking. I will link a PR for agnos builder soon.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added stale and removed stale labels Dec 3, 2024
@amoghmunikote
Copy link
Author

Added experimental ADB over USB functionality

amoghmunikote/GambitDriver@a76d0c7

Will test it out and commit it to main adbMenu branch

common/params.cc Outdated Show resolved Hide resolved
selfdrive/ui/qt/offroad/developer_panel.cc Show resolved Hide resolved
@adeebshihadeh
Copy link
Contributor

Nice, you got USB working?

@amoghmunikote
Copy link
Author

amoghmunikote commented Dec 4, 2024

I haven't tested it yet, I will in a little bit (Update; I've tested it out, and still doesn't work. I will continue working on it)

@@ -37,7 +45,6 @@ void DeveloperPanel::updateToggles(bool _offroad) {
btn->setEnabled(_offroad);
}

// longManeuverToggle should not be toggleable if the car don't have longitudinal control
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to delete this coment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, I'll re-add the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants