-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Debug Bridge Toggle #34092
base: master
Are you sure you want to change the base?
Android Debug Bridge Toggle #34092
Conversation
Sorry, I did not mean to mark it ready for review. Please revert it to the original state. |
Yes, that's the whole point. This also requires an accompanying agnos-builder PR to make it all work like SSH. |
Ok, I am just checking. I will link a PR for agnos builder soon. |
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Added experimental ADB over USB functionality amoghmunikote/GambitDriver@a76d0c7 Will test it out and commit it to main adbMenu branch |
Nice, you got USB working? |
Co-authored-by: Adeeb Shihadeh <[email protected]>
I haven't tested it yet, I will in a little bit (Update; I've tested it out, and still doesn't work. I will continue working on it) |
@@ -37,7 +45,6 @@ void DeveloperPanel::updateToggles(bool _offroad) { | |||
btn->setEnabled(_offroad); | |||
} | |||
|
|||
// longManeuverToggle should not be toggleable if the car don't have longitudinal control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason to delete this coment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I'll re-add the comment.
This PR is for #34041 (just a milestone for the bounty).
Current list of things required for bounty
For the sake of a concise recap, does the bounty require ADB to work over USB?