Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Developer Panel in Settings #33828

Merged
merged 14 commits into from
Oct 26, 2024

Conversation

AlexandreSato
Copy link
Contributor

@AlexandreSato AlexandreSato commented Oct 20, 2024

claim microbounty "Add Developer Panel in Settings #33822"
fixes #33822

  • SSH key setting (move from the Network tab)
  • Joystick mode
  • longitudinal maneuver report mode
  • Joystick and longitudinal maneuvers should be hidden on release branches.
  • Add developer settings to the ui preview bot
  • Change from button to toggles
  • only one toggle can be toggled at a given time
    developerpanel

@github-actions github-actions bot added the ui label Oct 20, 2024
Copy link
Contributor

github-actions bot commented Oct 20, 2024

UI Preview

settings_device : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_toggles : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
keyboard : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@AlexandreSato AlexandreSato changed the title claim microbounty "Add Developer Panel in Settings #33822" Add Developer Panel in Settings Oct 21, 2024
@AlexandreSato AlexandreSato marked this pull request as ready for review October 21, 2024 00:51
Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good:

  • Maneuver and joystick should be toggles
    • only one or none can be toggled at a given time
  • no need for a confirmation dialog

@adeebshihadeh adeebshihadeh marked this pull request as draft October 25, 2024 00:11
@AlexandreSato AlexandreSato marked this pull request as ready for review October 26, 2024 00:06
@adeebshihadeh adeebshihadeh merged commit 72a88c9 into commaai:master Oct 26, 2024
25 checks passed
@AlexandreSato AlexandreSato deleted the developer_panel branch October 26, 2024 00:49
AlexandreSato added a commit to AlexandreSato/openpilot that referenced this pull request Oct 28, 2024
After commaai#33828 this import is no more used here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants