-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Developer Panel in Settings #33828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSato
force-pushed
the
developer_panel
branch
from
October 20, 2024 18:16
8d884f0
to
5414daf
Compare
AlexandreSato
changed the title
claim microbounty "Add Developer Panel in Settings #33822"
Add Developer Panel in Settings
Oct 21, 2024
6 tasks
adeebshihadeh
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good:
- Maneuver and joystick should be toggles
- only one or none can be toggled at a given time
- no need for a confirmation dialog
AlexandreSato
added a commit
to AlexandreSato/openpilot
that referenced
this pull request
Oct 28, 2024
After commaai#33828 this import is no more used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
claim microbounty "Add Developer Panel in Settings #33822"
fixes #33822