Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honda: Odyssey 2021-25 #33708

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

Honda: Odyssey 2021-25 #33708

wants to merge 71 commits into from
+109 −108

Conversation

csouers
Copy link
Contributor

@csouers csouers commented Oct 2, 2024 •
edited
Loading

Checklist

  • (when out of dashcam) added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/opcar/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot:
  • route with stock system: might have this from before
  • car harness used (if comma doesn't sell it, put N/A): Bosch A

Prereqs:

@csouers
AF: sentry for fw id capture
c52c637
@csouers
Honda Odyssey 21-24
18c1144
@csouers
Merge remote-tracking branch 'upstream/master' into test_odyssey_c3
f96f612
@csouers
ignore. only once per file?
35b0a60
@csouers
nope
5aba47b
@csouers
bump dbc
4053296
@csouers
bring back alert only if have gone fast enough
0d41d58
@csouers
add test
c3fed94
@csouers
comment
c943f02
@csouers
works with pytest
6a74663
@csouers
test almost done. more car specific
b898b8e
@csouers
more
f851514
@csouers
mas
e44060c
@csouers
test done. little fixes. replay looked good.
9d82925
@csouers
bump dbc
5dec81d
@csouers
bump dbc. history may be weird here
dcd1d88
@csouers
Merge remote-tracking branch 'upstream/master' into test_odyssey_c3
bc2a29c
@csouers
bump dbc
1cd78de
@csouers
add footnote. big diff because generator
23996e4
@csouers
bump dbc
078a7de
@csouers
bump dbc
2da0e79
@csouers
car docs
375bf39
@csouers
bump dbc
b6d7666
@csouers
test for minsteer < 6mph
f10cb63
@csouers
bump dbc
8388165
@csouers
more test
6d31b55
@csouers
bump dbc
cfc944f
@csouers
comment
1af28e7
@csouers
cleaner test
52c848f
@csouers
rework
618473f
@github-actions github-actions bot added the car vehicle-specific label Oct 2, 2024
csouers
csouers commented Oct 2, 2024
View reviewed changes
selfdrive/car/car_specific.py Outdated Show resolved Hide resolved
@csouers csouers changed the title Car Port: 2021-25 Honda Odyssey Honda: Low speed steer & unresponsive EPS alerts Oct 2, 2024
@jyoung8607
Copy link
Collaborator

Just to set expectations, @sshane is in the middle of a big cleanup and refactor of car events. We'll still be able to accomplish what you need, but this particular PR will be on hold for a short time until that refactor merges.

@jyoung8607 jyoung8607 self-assigned this Oct 2, 2024
@jyoung8607 jyoung8607 mentioned this pull request Oct 2, 2024
Draft
@csouers csouers changed the title Honda: Low speed steer & unresponsive EPS alerts Honda: Odyssey 2021-25 (dashcam only) Oct 3, 2024
@csouers csouers changed the title Honda: Odyssey 2021-25 (dashcam only) Honda: Odyssey 2021-25 Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

@jyoung8607 jyoung8607 jyoung8607 left review comments

Assignees

@jyoung8607 jyoung8607

Labels
car vehicle-specific stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csouers @jyoung8607 @sshane