Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCA Giorgio: Alfa Romeo Stelvio / Giulia #33618

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
3 changes: 3 additions & 0 deletions launch_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ if [ -z "$AGNOS_VERSION" ]; then
fi

export STAGING_ROOT="/data/safe_staging"

# FIXME: revert once UDS/VIN fingerprinting in place
export FINGERPRINT="ALFA_ROMEO_STELVIO_1ST_GEN"
2 changes: 1 addition & 1 deletion panda
5 changes: 5 additions & 0 deletions selfdrive/car/car_specific.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ def update(self, CS: car.CarState, CS_prev: car.CarState, CC: car.CarControl):
if self.low_speed_alert:
events.add(EventName.belowSteerSpeed)

# TODO: Shouldn't be necessary. Refactor CarSpecificEvents with a simple default case, override only if necessary.
# Default case should cover FCA Giorgio, Subaru, Mazda, maybe Ford. Further simplification possible.
elif self.CP.carName == 'fca_giorgio':
events = self.create_common_events(CS.out, CS_prev)

else:
raise ValueError(f"Unsupported car: {self.CP.carName}")

Expand Down
3 changes: 2 additions & 1 deletion selfdrive/test/process_replay/test_processes.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
]

# dashcamOnly makes don't need to be tested until a full port is done
excluded_interfaces = ["mock", "tesla"]
# FIXME: Revert before merging, need a process_replay test route for fca_giorgio
excluded_interfaces = ["mock", "tesla", "fca_giorgio"]

BASE_URL = "https://commadataci.blob.core.windows.net/openpilotci/"
REF_COMMIT_FN = os.path.join(PROC_REPLAY_DIR, "ref_commit")
Expand Down
Loading