-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cluster displayed set speed skipping certain mph values #33030
Conversation
Tested on 2016 civic, 2018 accord, and 2022 ev6 with hda2 using openpilot longitudinal and the set speed seems to always be correct now. |
@jyoung8607 can you try this? |
d9a86eb
to
b17b152
Compare
I will be test-driving some harness samples in the next couple days, I'll validate this at the same time. |
b17b152
to
e70a7dc
Compare
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
When incrementing set speed, convert to display units, increment in display units, then convert back to original units.
No clusters display set speed units with decimal places, and this ensures when you convert the stored value to any units and round to the nearest integer you always get the desired set speed value.
openpilot/selfdrive/car/volkswagen/carcontroller.py
Line 102 in 0907b30