Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Trying to run Setup-on-retry without Docker by installing directly. #31606

Closed
wants to merge 0 commits into from

Conversation

knownotunknown
Copy link

@knownotunknown knownotunknown commented Feb 27, 2024

For: #30706

I ditched docker, and I'm trying to install all the dependencies directly. I still need to make all the relevant dependencies accessible to the files that use them, and I'm not sure I'm caching correctly, but the opportunity for speedup by installing directly seems promising:

~44 seconds without caching (including dependency installing steps moved outside of setup-with-retry): https://github.com/knownotunknown/openpilot/actions/runs/8060095839/job/22015556248

Also, temporarily ignoring a Python deprecation warning, but also planning on fixing that eventually: https://stackoverflow.com/questions/76043689/pkg-resources-is-deprecated-as-an-api

Not sure if this is enough to lock the bounty, but thought I'd share what I was working on in case it was.

Copy link
Contributor

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@adeebshihadeh
Copy link
Contributor

Bounty locked!

@adeebshihadeh adeebshihadeh marked this pull request as draft February 27, 2024 18:43
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

1 similar comment
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@knownotunknown
Copy link
Author

Not sure why I kept getting the bot message because my PR was already a draft. Also, I'm still working on this, but I'm honestly not really on the right track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants