url_file: fix non-200 files being cached #30886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnewb1
commented
Jan 2, 2024
|
|
||
| patch_length = mock.patch.object(URLFile, "get_length_online", get_length_online_mock) |
There was a problem hiding this comment.
old test just mocked the get_length function, to force a -1 response, new test does a full mock of a web server as a more E2E test
sshane
reviewed
Jan 2, 2024
Co-authored-by: Shane Smiskol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-200 responses seem to be cached after pycurl removal here: #30771
noticed when doing a car port to test the non-azure route stuff #30828