Toyota: Enable Resume OP w/ Brake Hold Active #29057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows brake hold active state to resume openpilot
adding or condition
commenting out change that disabled resuming OP while brake hold was active
Freezes intgrator while brake hold is active, allowing for OP to be resumed without an integrator runaway present
jsegill
changed the title
|
I believe disallowing engagement when the auto brake hold feature is on is an intentional decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toyota Bug Fix- Allows OP to be resumed while the Brake Hold is Active. The changes prevent the integrator from continuing to ramp up.
Tested on route 4ecfcac756318cbf|2023-07-03--09-32-23--0 and verified via log data in Cabana.
Route: 4ecfcac756318cbf|2023-07-03--09-32-23--0
Attempt at fixing issue: Unable to activate OP while brake hold active #33988