macos: use /tmp instead of /dev/shm #34097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…makes tests not really work fine on mac
More shm updates for macos
devtekve
changed the title
|
This is not the right way to support msgq on macOS. Additionally, the approach in commaai/msgq#635 is also incorrect. |
|
Great! Good that I wasn’t adding support for msgq on macOS hahaha, this is
done because running tests fails on macOS because they try to do things on
/dev/shm
…On Sun, Nov 24, 2024 at 3:12 PM Dean Lee ***@***.***> wrote:
This is not the right way to support msgq on macOS.
—
Reply to this email directly, view it on GitHub
<#34097 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2XERXHXUM433P454MTL232CHNEHAVCNFSM6AAAAABSMB6CQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGAZDKMJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
Thanks! Feel free to open up a macOS issue and throw complaints in there until it's in a good state, similar to the old new Cabana discussion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things (specially around tests) seem to rely on
/dev/shmitself existing.OPENPILOT_PREFIXcan't be used when ZMQ which is needed for macos... So I thought it'd be better to just give a path for the "/dev/shm" on macos on /tmp which is the closest we can get to itThis is NOT intended to bring msgq support into MacOS.
It is only intended to allow a more graceful approach as things around still seem to rely indirectly on the path
/dev/shmeven though you are using ZMQ