cabana: issue filtering by addresses in FindSignal tool (#34283)

fixed filtering by addresses issue in cabana
commaai · Dec 18, 2024 · af50820 · af50820
1 parent 17ca638
commit af50820
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tools/cabana/tools/findsignal.cc b/tools/cabana/tools/findsignal.cc
@@ -225,7 +225,7 @@ void FindSignalDlg::setInitialSignals() {
   model->initial_signals.clear();
 
   for (const auto &[id, m] : can->lastMessages()) {
-    if (buses.isEmpty() || buses.contains(id.source) && (addresses.isEmpty() || addresses.contains(id.address))) {
+    if ((buses.isEmpty() || buses.contains(id.source)) && (addresses.isEmpty() || addresses.contains(id.address))) {
       const auto &events = can->events(id);
       auto e = std::lower_bound(events.cbegin(), events.cend(), first_time, CompareCanEvent());
       if (e != events.cend()) {