Refactor safety to support combinatoric number of configurations #1800
+336
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed when safety was moved from panda to opendbc. This is needed in order for memcpy to be available for safety tests as it is in production.
ccdunder
force-pushed
the
safety-refactor1
branch
from
ef55a8d to
1acfd9b
Compare
ccdunder
force-pushed
the
safety-refactor1
branch
from
a044a7b to
854127d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only functional change right now is that the accelerator and cruise button rx checks are now added individually/specifically based on the params (vs. adding all and requiring one or more to succeed).