Rivian: add Safety #1753
Open
Rivian: add Safety #1753
+238
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check the failing safety tests? |
|
Yes, I am currently traveling. I will have a look this evening. |
add _vehicle_moving_msg
add _vehicle_moving_msg
sshane
reviewed
Feb 23, 2025
Comment on lines
21
to
22
| int torque_driver_new = ((((GET_BYTE(to_push, 2) << 4) | (GET_BYTE(to_push, 3) >> 4)) * 0.1) - 205); | ||
| update_sample(&torque_driver, torque_driver_new); |
There was a problem hiding this comment.
driver_torque_allowance is an integer, but you're converting this to a very small float (that's getting truncated to an int with update_sample), are you sure this is doing anything?
we probably want to undo the factor (but keep the offset) and process as a raw int in openpilot and opendbc safety
There was a problem hiding this comment.
so subtract 205/0.1=2050 here
lukasloetkolben
force-pushed
the
rivian_safety
branch
from
af56078 to
ba6111a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.