Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW MEB: Platform support #1696

Draft
wants to merge 658 commits into
base: master
Choose a base branch
from
Draft

VW MEB: Platform support #1696

wants to merge 658 commits into from

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Feb 6, 2025

Support for the Volkswagen ID family and other MEB vehicles. Thanks and credit to @infiniteCable.

  • Test route: TBD
  • Harness: Volkswagen C (issue link TBD)

Safety layer TODO

  • VW MEB: CAN ignition panda#2160
  • Power-percentage control on driver torque input
  • Verify CAN ignition is actually necessary
  • Move to DEBUG until comma releases from dashcam
  • Look for opportunities to consolidate code with MQB and MQBevo
    • checksum support
    • rx steering angle, driver input torque
  • Write CI tests
    • General (wheel speeds, gas/brake, driver input torque, ACC buttons, ACC state)
    • Lateral control (curvature)
    • Longitudinal control (acceleration)

Driving layer TODO

  • Switch initial vehicle support from Cupra Born to Volkswagen ID.4, for testing at comma_hack
  • controls: publish current curvature in CarControl openpilot#34679
  • VW MEB: CAN database and checksum support #1816
  • Lateral control
  • Longitudinal control
    • Move behind alpha long toggle
    • Fix cruise fault logic at startup/standstill
    • Verify nature/need of the ACC API fault-avoidance carcontroller code
    • Verify nature/need of special HUD code (temporarily set aside in 42b708b)
    • Verify radar code is doing what we need
  • Look for opportunities to consolidate code with MQB and MQBevo
    • Use DBC generator for common messages (too many subtle differences)
    • carstate
    • mqbcan/mebcan
    • checksum support
    • checksum tests (deferred, CAN-FD messages are doing something weird)
  • Camera integration (in addition to existing gateway integration)
    • Radar UDS knockout, if possible
  • Fix BSM false firing
  • Fix comfort turn signals
  • EA mitigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can related to CAN tools, aka opendbc/can/ car safety vehicle-specific safety code car related to opendbc/car/ DBC signals volkswagen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants