CANParser: direct capnp to vector[CanData] conversion #1452
+18
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the conversion process by eliminating unnecessary intermediate steps and directly converting Capnp data to
vector[CanData]
within the C++ space. Previously, the conversion involved multiple stages:vector[CanData]
(C++)vector[CanData]
→ Python nested list (Cython)vector[CanData]
(Cython)vector[CanData]
back toCanParser::update
from Cython to C++Now, the conversion occurs directly from capnp to
vector[CanData]
, encapsulated within theParsedCanData
class, which passes thevector[CanData]
by pointer. This approach simplifies the conversion pipeline and reduces overhead.Key changes:
Encapsulated
vector[CanData]
inParsedCanData
: (can_capnp_to_list: direct capnp to vector[CanData] conversion openpilot#33952)Parse capnp data directly into
ParsedCanData
's membervector[CanData]
in C++:Efficiently pass the data pointer to
CanParser.update
:By removing the redundant conversion layers, this PR improves both performance and resource efficiency. The change is particularly beneficial for high-frequency CAN processing in real-time, on-device environments, resulting in faster execution and lower system overhead.