Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: set pcm_accel_net when possible #1448

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Toyota: set pcm_accel_net when possible #1448

merged 1 commit into from
Nov 6, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 6, 2024

Useful when working on porting this to other cars and having a list of cars that don't have this message

@sshane sshane added car related to opendbc/car/ toyota labels Nov 6, 2024
@sshane sshane marked this pull request as ready for review November 6, 2024 22:04
@sshane sshane changed the title Toyota: set accel_net when possible Toyota: set pcm_accel_net when possible Nov 6, 2024
@sshane sshane merged commit 6be3d04 into master Nov 6, 2024
6 checks passed
@sshane sshane deleted the always-accel-net branch November 6, 2024 22:58
@sshane
Copy link
Contributor Author

sshane commented Nov 6, 2024

@deanlee does your new CANParser refactor allow checking in cp.vl? I can make this a constant set if not

@deanlee
Copy link
Contributor

deanlee commented Nov 7, 2024

@sshane : it support, ReadonlyDict inherits from Mapping, collections.abc.Mapping already provides the default implementations for many dictionary-like methods, including in, values(), items()... Therefore, we only need to implement __getitem__, __iter__, and __len__. Mapping can use them to support other dict methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants