Ford: enable radar #1430
Merged
Ford: enable radar #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sshane by the time I submitted those PRs, the debug script had already been broken for some time following the refactoring of the card and related modules. |
sshane
added a commit
that referenced
this pull request
Oct 30, 2024
|
fixed broken: commaai/openpilot#33908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAN parsing and accessing the messages and signals from the CANParser dicts is mostly the slowest part, clustering takes only ~10-20% of the time.
@deanlee I see you have some optimization PRs, do they make a significant difference? Please post time differences using the debug script if you haven't and I'll check it out soon!