Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: always send ACC at 33 Hz #1390

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Toyota: always send ACC at 33 Hz #1390

merged 7 commits into from
Nov 7, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 18, 2024

this PR is a start at putting all ACC related calculations into the 33hz update loop. this allows you to reason about rate limiting and such much easier if everything is calculated/sent at the same rate

  • openpilot long: always send at 33 Hz, even when canceling (similar to other ports)
  • stock long
    • unsupported dsu: continue to send cancel cmd at 100 Hz (similar to other button cancel ports)
    • normal dsu: continue to send acc message cancel at 100 Hz (same)

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Oct 18, 2024
@sshane sshane marked this pull request as ready for review October 18, 2024 23:11
@sshane sshane added the cleanup label Nov 6, 2024
@sshane sshane merged commit 2d08ede into master Nov 7, 2024
4 checks passed
@sshane sshane deleted the toyota-acc-33hz branch November 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ cleanup toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant