Scons generate dbc files #1329
Scons generate dbc files #1329
Conversation
bongbui321
force-pushed
the
scons_generate_dbc
branch
from
4ef1153
to
06b2e6f
Compare
bongbui321
force-pushed
the
scons_generate_dbc
branch
from
8f6bfb7
to
de7ad25
Compare
|
Abstracted out the fuzzy find for generators in |
| from opendbc.dbc.generator.generator import (generated_suffix, generator_path, opendbc_root, \ | ||
| get_python_generator_scripts, get_source_dbc_files) | ||
| Import('env') | ||
|
|
There was a problem hiding this comment.
this looks way too complicated. why not just glob everything in generator/*?
There was a problem hiding this comment.
not all .dbc within generator dir being the sources for the generated DBCs :(
glob.glob(f"{generated_path//.dbc}" with added conditional statements and replacing the .dbc suffix with _generated.dbc would be the same as what you referenced. All generated dbcs will be put into generator/../ while the source dbc could be from anywhere within the generator path
it's easier abstract out the search functions to get the paths to generated dbcs, and to delete them when run with scons -c
| for f in glob.glob(f"{generator_path}/*/*.py"): | ||
| subprocess.check_call(f) | ||
|
|
||
| def get_source_dbc_files(generator_path: str) -> defaultdict[str, list[str]]: |
There was a problem hiding this comment.
same here, shouldn't need to touch this script
resolve #1309