Toyota: DBC for RAV4 Prime and Sienna #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SG_ STEER_RATE : 35|12@0- (1,0) [-2000|2000] "deg/s" XXX | ||
| SG_ STEER_FRACTION : 39|4@0- (0.1,0) [-0.7|0.7] "deg" XXX | ||
|
|
||
| BO_ 170 WHEEL_SPEEDS: 8 XXX |
There was a problem hiding this comment.
all this is new? or are they just different addrs?
There was a problem hiding this comment.
@jyoung8607 Yeah can we make a common DBC to reduce duplication? ADAS messages can be split out similar to what we did for Honda.
There was a problem hiding this comment.
It definitely needs a cleanup pass, just needed it out of critical path for this week's targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing these in first, for benefit of Panda safety testing.