Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyundai CAN Longitudinal: Enable for Camera SCC cars #1282

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Hyundai CAN Longitudinal: Enable for Camera SCC cars #1282

merged 6 commits into from
Nov 21, 2024

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Sep 25, 2024 •
edited
Loading

Description

openpilot longitudinal control support for CAN-based HKG cars that have the following messages send from the car on bus 2:

  • SCC11
  • SCC12
  • SCC13
  • SCC14
  • FCA11
  • FCA12

Currently with 2022 Hyundai Kona EV, without radar disable. As the messages send from the car on bus 2, we block the messages and send our own longitudinal commands to bus 0.

FCA11 and FCA12 do stock FCW and AEB, and are forwarded from the LKAS camera to the car.

Supersedes

Requires

@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Sep 25, 2024
@sunnyhaibin sunnyhaibin mentioned this pull request Sep 25, 2024
Open
@sunnyhaibin sunnyhaibin changed the title Hyundai CAN: Longitudinal support for Camera SCC cars Hyundai CAN Longitudinal: Enable for Camera SCC cars Sep 26, 2024
@sunnyhaibin
Copy link
Contributor Author

Route with stock FCW active: d3a039910163c67a/000000cb--b5898024e5

image

@sunnyhaibin
Merge remote-tracking branch 'commaai/opendbc/master' into hyundai-ca…
5a496b0 
…n-camera-scc-long

# Conflicts:
#	opendbc/car/hyundai/interface.py
@sunnyhaibin
Copy link
Contributor Author

Another working test route: ecb854b94fdfa4d5/00000001--70960afd85

@sunnyhaibin
Copy link
Contributor Author

Test route with stock AEB actively braking for the car! d3a039910163c67a/000000d1--754d5d6111
image

@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Nov 21, 2024
@adeebshihadeh adeebshihadeh reopened this Nov 21, 2024
@adeebshihadeh
Copy link
Contributor

I resolved the conflict, but can't push to the branch because it's from the sunnypilot org. Can you add write access for me, shane, and jason to the repo you're gonna make PRs from?

@sunnyhaibin
Copy link
Contributor Author

I resolved the conflict, but can't push to the branch because it's from the sunnypilot org. Can you add write access for me, shane, and jason to the repo you're gonna make PRs from?

Invitation sent!

@adeebshihadeh adeebshihadeh merged commit 6c68673 into commaai:master Nov 21, 2024
4 checks passed
@sshane
Copy link
Contributor

sshane commented Nov 22, 2024

Fails test_models in openpilot: https://github.com/commaai/openpilot/actions/runs/11966321616/job/33361765473

sshane added a commit that referenced this pull request Nov 22, 2024
@sshane
Revert "Hyundai CAN Longitudinal: Enable for Camera SCC cars (#1282)"
7e16de6 
This reverts commit 6c68673.
@sshane sshane mentioned this pull request Nov 22, 2024
Merged
sshane added a commit that referenced this pull request Nov 22, 2024
@sshane
Revert "Hyundai CAN Longitudinal: Enable for Camera SCC cars" (#1518)
fb6ad76 
Revert "Hyundai CAN Longitudinal: Enable for Camera SCC cars (#1282)"

This reverts commit 6c68673.
@sunnyhaibin sunnyhaibin mentioned this pull request Dec 7, 2024
Merged
@sunnyhaibin
Copy link
Contributor Author

@adeebshihadeh @sshane Reopened #1563 with fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh approved these changes

Assignees
No one assigned
Labels
car related to opendbc/car/ hyundai stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunnyhaibin @adeebshihadeh @sshane