Icon: fixed apple icon alignment #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to new-connect! Make sure to:
deployed preview: https://34.connect-d5y.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple logo was not aligned with the apple sign up button text. I aligned the logo and also replaced the apple svg with an svg that is the same height and width since the other logos had the same height and width.
The google and github btn were lining up while apple bttn wasnt. Main reason was the Google and Github bttn have the same amount of characters in the text while the apple button is too short by 2 characters.
I did
 so that the apple button text would have the same amount of characters as the others which would line up the icon and text, versus adding another div with flexbox or modifying the button component for right nowOld vs New
compare-apple-logo.mp4