Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buttons squished #135

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

mikhailmtion
Copy link
Contributor

@mikhailmtion mikhailmtion commented Jan 17, 2025

This resolves issue #134 and #82

Before
before

After
after

Copy link

github-actions bot commented Jan 17, 2025

deployed preview: https://135.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@incognitojam
Copy link
Member

When the list of devices doesn't fit and you scroll in the drawer, the background height seems to be limited to the screen height (I reproduced this by duplicating the <For each={props.devices}> in DeviceList)
image

Think you can fix that?

@mikhailmtion
Copy link
Contributor Author

mikhailmtion commented Jan 21, 2025

@incognitojam Added scroll
Maybe we'll add a margin between the ListItem?

scroll

@incognitojam incognitojam changed the title Fix: Log out buttons squished fix: buttons squished Jan 31, 2025
@incognitojam incognitojam merged commit a1f34b2 into commaai:master Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants