-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle no start time -> use created time instead #109
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th time zone displays
4aff257
to
e2598da
Compare
…review is failing
e2598da
to
a86a23a
Compare
…s, hopefully for clearer logs
deployed preview: https://109.connect-d5y.pages.devWelcome to new-connect! Make sure to:
Mobile
Desktop |
This PR is massive. Can you split it up? |
@adeebshihadeh yeah I can split it apart. Give me a day or so |
Hey @pauljones0, just a heads up, but I think you may have misunderstood the requirements:
The goal is to use the create_time for ordering, not to use it to display date/time in the same way you'd display start_time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Workflow and Testing Improvements
Addresses bounty #60 by enhancing the preview #99 workflow with things not caught before, and adding test coverage.
Changes
Testing
Dependencies
Date Handling
GitHub Actions
Code Style
Testing
All tests pass locally and in CI. The preview deployment workflow has been verified with multiple test runs.