Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no start time -> use created time instead #109

Closed

Conversation

pauljones0
Copy link

@pauljones0 pauljones0 commented Nov 2, 2024

Preview Workflow and Testing Improvements

Addresses bounty #60 by enhancing the preview #99 workflow with things not caught before, and adding test coverage.

Changes

Testing

  • Added Vitest unit tests for RouteHeader component to verify date/time handling, these should run automatically in the CI/CD pipeline

Dependencies

  • Added Prettier plugin for Tailwind CSS to improve formatting consistency

Date Handling

  • Updated route date formatting to handle missing start times gracefully
  • Falls back to creation time when start time is unavailable

GitHub Actions

  • Cleaned up formatting and documentation in workflow files

Code Style

  • Improved responsive layout for cards:
    • Flex row layout on larger screens
    • Flex column layout on mobile
    • Centered card alignment
    • Increased bottom margin for "load more" button

Testing

All tests pass locally and in CI. The preview deployment workflow has been verified with multiple test runs.

@pauljones0 pauljones0 marked this pull request as draft November 2, 2024 07:55
@pauljones0 pauljones0 changed the title Fixing more EOL to LF Handle no start time -> use created time instead Nov 2, 2024
@pauljones0 pauljones0 force-pushed the handle-routes-with-no-time branch from 4aff257 to e2598da Compare November 2, 2024 08:23
@pauljones0 pauljones0 force-pushed the handle-routes-with-no-time branch from e2598da to a86a23a Compare November 2, 2024 08:27
Copy link

github-actions bot commented Nov 2, 2024

deployed preview: https://109.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@pauljones0 pauljones0 marked this pull request as ready for review November 2, 2024 09:16
@adeebshihadeh
Copy link
Contributor

This PR is massive. Can you split it up?

@pauljones0
Copy link
Author

@adeebshihadeh yeah I can split it apart. Give me a day or so

@knownotunknown
Copy link

Hey @pauljones0, just a heads up, but I think you may have misunderstood the requirements:

Requirements

hide the date/time
show "timeless" routes in the correct order with the rest of routes

The goal is to use the create_time for ordering, not to use it to display date/time in the same way you'd display start_time.

@pauljones0 pauljones0 closed this by deleting the head repository Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants