Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route): control video via the timeline #103

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

t1mp4
Copy link
Contributor

@t1mp4 t1mp4 commented Sep 23, 2024

As suggested by #64. Handles both mouse and touch input. Tested on iPhone 14.

@BBBmau
Copy link
Contributor

BBBmau commented Sep 23, 2024

Works great! Tested on Pixel 6a

screen-20240923-145907.3.mp4

@t1mp4 t1mp4 reopened this Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

deployed preview: https://103.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@incognitojam incognitojam added the enhancement New feature or request label Jan 20, 2025
@incognitojam
Copy link
Member

Thanks for the PR! Do you know how to stop the vertical scrolling of the page when you drag across the timeline?

@incognitojam incognitojam changed the title Feat(route): add ability to control video via the timeline feat(route): control video via the timeline Jan 22, 2025
@incognitojam incognitojam merged commit 2d69bc4 into commaai:master Jan 22, 2025
3 checks passed
@t1mp4
Copy link
Contributor Author

t1mp4 commented Jan 22, 2025

Thanks for the PR! Do you know how to stop the vertical scrolling of the page when you drag across the timeline?

See #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants