-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeline zoom stack #419
timeline zoom stack #419
Conversation
7f2769c
to
3e40c45
Compare
It would be nice to have a couple of browser tests for this, for example:
|
Co-authored-by: Cameron Clough <[email protected]>
I'm going to see what I can do. Not entirely familiar with this, but by browser tests you mean something like these puppeteer test cases (https://github.com/commaai/connect/tree/master/src/__puppeteer__)? |
Yep that's the right place |
Implemented your suggested puppeteer test cases in drive.test.js. Checking for url changes after button click should be enough for detecting expected navigation |
Push/pop timeline range actions. Save previous zooms when pushing new timeline range. Go back to route bounds, when no previous zoom is available.