Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline zoom stack #419

Merged
merged 11 commits into from
Aug 6, 2023
Merged

timeline zoom stack #419

merged 11 commits into from
Aug 6, 2023

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Aug 2, 2023

Push/pop timeline range actions. Save previous zooms when pushing new timeline range. Go back to route bounds, when no previous zoom is available.

@fredyshox fredyshox marked this pull request as ready for review August 3, 2023 07:29
@incognitojam
Copy link
Collaborator

incognitojam commented Aug 4, 2023

It would be nice to have a couple of browser tests for this, for example:

  • opening the demo route from URL:
    • assert that the back button is disabled
    • assert that clicking the close button takes you to the drive list
  • opening a route URL with a shorter time range selected:
    • assert that clicking the back button takes you to the full route

@fredyshox
Copy link
Contributor Author

I'm going to see what I can do. Not entirely familiar with this, but by browser tests you mean something like these puppeteer test cases (https://github.com/commaai/connect/tree/master/src/__puppeteer__)?

@incognitojam
Copy link
Collaborator

Yep that's the right place

@fredyshox
Copy link
Contributor Author

Implemented your suggested puppeteer test cases in drive.test.js. Checking for url changes after button click should be enough for detecting expected navigation

@incognitojam incognitojam changed the title DriveView: fix back button timeline zoom stack Aug 6, 2023
@incognitojam incognitojam merged commit 753ec48 into master Aug 6, 2023
4 checks passed
@incognitojam incognitojam deleted the timeline-range-push-pop branch August 6, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants