Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigate to coordinates endpoint #408

Closed
wants to merge 9 commits into from
Closed

Conversation

fredyshox
Copy link
Contributor

Prototype of /navigate?lat=LAT&long=LONG route, which triggers navigation prompt to specified coordinates for current dongle id.

@gregjhogan
Copy link
Member

gregjhogan commented Jul 24, 2023

Android can support this nicely via PWA manifest share_target with the addition of making a HEAD request to the URL passed in to get the lat/long of the shared location (and the name of the place selected if you selected a location with a name in google maps).

@fredyshox
Copy link
Contributor Author

fredyshox commented Jul 24, 2023

That's the goal 👍 It's slightly more complicated on iOS, because it would need custom Shortcut to appear in the share sheet, but it's definitely doable.

@fredyshox fredyshox marked this pull request as ready for review July 31, 2023 06:57
@fredyshox
Copy link
Contributor Author

CORS prevents me from expanding shortened gmaps url using HEAD request. Will probably need additional endpoint on backend side for that.

@gregjhogan
Copy link
Member

That is annoying, you could probably use a hidden iframe to load the URL and inspect it instead, but a new back end API endpoint may be better (may even want to use the google maps API instead of a head request). Also, I think your url parsing for google maps is extracting the center of the map and not the coordinates of the place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants