Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup llvm and qemu packages #347

Closed
wants to merge 5 commits into from
Closed

Cleanup llvm and qemu packages #347

wants to merge 5 commits into from

Conversation

andiradulescu
Copy link
Collaborator

@andiradulescu andiradulescu commented Sep 6, 2024 •
edited
Loading

Removes llvm/clang 18 and qemu-user and keeps llvm/clang 17.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

✅ AGNOS update 8fd7f52 ready

In an openpilot branch, download agnos.json in system/hardware/tici/ and update AGNOS_VERSION to "8fd7f520a11c1b21f8a2889d3e302299ece5bab0" in launch_env.sh.

For flashing locally, download and unarchive the images in agnos-builder/output and flash with ./flash_all.sh.

Images:

Stats:

3.8G	/
620M	/usr/local/venv
850M	/usr/lib/aarch64-linux-gnu
260M	/usr/lib/gcc
191M	/usr/lib/llvm-17
155M	/usr/lib/arm-linux-gnueabihf
365M	/usr/bin
327M	/usr/share
166M	/usr/comma

@andiradulescu andiradulescu marked this pull request as ready for review September 6, 2024 16:42
@andiradulescu andiradulescu changed the title Cleanup apt packages Cleanup llvm and qemu packages Sep 6, 2024
adeebshihadeh
adeebshihadeh reviewed Sep 6, 2024
View reviewed changes
userspace/base_setup.sh
Comment on lines +110 to +114
# keep LLVM 17 (not 18 as in 24.04, since mesa/rusticl/etc seems to use 17)
# clang & llvm metapackages install LLVM 18 (which is not installed anymore)
apt-fast install --no-install-recommends -yq \
clang-17 \
llvm-17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would worry about this later. we really don't want to add hacks now for future concerns. they'll be easy enough to change when we know we need them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t like this change, also, but 24.04 mesa depends right now on llvm-17. we can’t remove mesa since we need it for software rendering and also in mainline.

installing llvm 24.04 meta package installs llvm-18.

so, because of this we have both llvm-17 and llvm-18 installed, taking an extra ~150 MB of space.

we can avoid removing and keep both, until mesa updates to llvm-18, and llvm-17 will not get installed anymore (without any changes).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robin-reckmann what’s your take on this? I’m curious about your opinion.

robin-reckmann
robin-reckmann reviewed Sep 10, 2024
View reviewed changes
Dockerfile.agnos
@@ -219,7 +223,7 @@ COPY ./userspace/files/apt.conf /etc/apt/apt.conf
COPY VERSION /VERSION

# ################## #
# #### Cleaunup #### #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most important cleaunup

@andiradulescu
Copy link
Collaborator Author

andiradulescu commented Sep 10, 2024 •
edited
Loading

Closing this for now. Will revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh left review comments

@robin-reckmann robin-reckmann robin-reckmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andiradulescu @adeebshihadeh @robin-reckmann