Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added displaying a list of servers [#3] #53

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Added displaying a list of servers [#3] #53

merged 1 commit into from
Jun 9, 2024

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jun 9, 2024

  • Android: Added the navigation suite scaffold.
  • iOS: Added the navigation view.

Closes #3

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added displaying a list of servers [comixed#3]
1909806 
 * Android: Added the navigation suite scaffold.
 * iOS: Added the navigation view.
@mcpierce mcpierce added the enhancement A pull request containing a new or refactored feature. label Jun 9, 2024
@mcpierce mcpierce added this to the 0.1 milestone Jun 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mcpierce mcpierce merged commit a37d7a9 into comixed:main Jun 9, 2024
3 of 4 checks passed
@mcpierce mcpierce deleted the feature/issue-3 branch June 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A pull request containing a new or refactored feature.
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

The application displays a list of servers.
1 participant
@mcpierce