-
Notifications
You must be signed in to change notification settings - Fork 9k
Support Iluvatar CoreX #8585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support Iluvatar CoreX #8585
Conversation
46d9466
to
da50a8e
Compare
cuda_malloc.py
Outdated
@@ -50,7 +50,17 @@ def enum_display_devices(): | |||
"GeForce GTX 1650", "GeForce GTX 1630", "Tesla M4", "Tesla M6", "Tesla M10", "Tesla M40", "Tesla M60" | |||
} | |||
|
|||
def is_ixuca(): | |||
try: | |||
import torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you import torch before setting the cuda malloc option it completely breaks cuda malloc on nvidia gpus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code. Using _load_torch_submodule to check if is_ixuca like the get version code, and return early in cuda_malloc_supported if is_ixuca.
- Created shared _load_torch_submodule() helper to handle all the importlib boilerplate like version.py, corex.py and so on.
- Updated is_ixuca to use the helper and not import torch directly to break cuda malloc on nvidia gpus.
- Made the version check code more concise and robust by using the helper
2ec7155
to
49529c7
Compare
…portlib boilerplate like version.py, corex.py and so on. 2. Updated is_ixuca to use the helper and not import torch directly to break cuda malloc on nvidia gpus. 3. Made the version check code more concise and robust by using the helper
49529c7
to
fa8a063
Compare
close #8584
The PR was validated on Iluvatar CoreX GPUs. We need to install Iluvatar Corex Toolkit first. Then run:
We use the sd_xl_base_1.0 model and get the default workflow's results as below: