Fix MPS tensor contiguity issue in tiled_scale_multidim for arbitrary image sizes #8352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Made: Added samples = samples.contiguous() at the start. Added tile = (min(tile[0], samples.shape[2]), min(tile[1], samples.shape[3])) for dynamic tile sizing. Modified output[b:b+1] = function(s.contiguous()).to(output_device) in the single-tile case. Modified ps = function(s_in.contiguous()).to(output_device) in the tiled loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RuntimeError: view size is not compatible with input tensor's size and stride when using ImageUpscaleWithModel on macOS with MPS backend, which required 512x512 images.