Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strength input to Differential Diffusion #5709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EricBCoding
Copy link

@EricBCoding EricBCoding commented Nov 22, 2024

Hi,

The Differential Diffusion node from #2876 is awesome for inpainting tasks, but the effect is too strong at times. It is challenging to use when generating a subject that has little in common with the original.

Even at a denoising strength of 100%, Differential Diffusion often overwhelms the prompt. But if we blend the adjusted binary mask with the original, we can find a sweet spot. The example below was performed with Euler/Beta, 4 steps, 100% denoising strength. Model is flux1-dev.sft with distillation LoRAs for speed.

differential_diffusion_strength

50-75% Differential Diffusion strength feels a lot more usable in practice than 100%. Here's one more comparison if you'll indulge me:

The prompt was "Donald Trump." That guy in the middle looks like he'd be fun at parties, but he's definitely not Trump.

@ltdrdata
Copy link
Collaborator

Wouldn't it be better to skip the blending logic when the strength is set to 1.0?

@EricBCoding
Copy link
Author

@ltdrdata The blend operation is nearly instantaneous either way (at least at 1024x1024), but you're right, a conditional check is probably smarter. 🙂 Updated the code.

@ltdrdata ltdrdata added the Good PR This PR looks good to go, it needs comfy's final review. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants