Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escrow.charge example #432

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix escrow.charge example #432

merged 1 commit into from
Apr 30, 2024

Conversation

danswann
Copy link
Member

@danswann danswann commented Apr 30, 2024

Problem

The example escrow script had the conditions backwards. If escrow.charge returns an object, you want to forward it to the player. If it is null, the charge is paid.

Added semis for consistency with the line that had one.

Example was backwards.
Copy link
Member

@matr1x-hackmud matr1x-hackmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm(TM)

@matr1x-hackmud matr1x-hackmud merged commit 0c00a84 into main Apr 30, 2024
4 checks passed
@matr1x-hackmud matr1x-hackmud deleted the danswann/escrow-fix branch April 30, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants