feat: 104 Export menu plugin #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusz
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Because this is somewhat Alliander specific. Should we separate it from the other plugins?
What do you think @Sander3003?
Comment on lines
+79
to
+88
| const a = document.createElement('a'); | ||
| a.download = this.docName + '-104-signals.csv'; | ||
| a.href = URL.createObjectURL(csvBlob); | ||
| a.dataset.downloadurl = ['text/csv', a.download, a.href].join(':'); | ||
| a.style.display = 'none'; | ||
|
|
||
| document.body.appendChild(a); | ||
| a.click(); | ||
| document.body.removeChild(a); | ||
| URL.revokeObjectURL(a.href); |
There was a problem hiding this comment.
This is a nice hack. I assume there is no other way to do this
There was a problem hiding this comment.
I pretty much copied the code from here https://github.com/com-pas/compas-open-scd/blob/main/packages/compas-open-scd/src/menu/ExportIEDParams.ts#L296
After googling for a while the hidden <a> element seems to be the only way, we might want to look for a way to make this function reuseable, because at the moment it has been copied at least three times between different plugins.
|
We will leave the plugin in this repo for the time being. |
trusz
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #334