Skip to content

Commit

Permalink
Turn back on Scala 3 tests, enable big-case-class tests (#557)
Browse files Browse the repository at this point in the history
Turn on tests to verify
#386

Scala 3 tests were accidentally disabled in
#553, this re-enables them

The big-case-class tests do work, with the caveat you need to set
`-Xmax-inlines` to be greater than the width of your case class, and the
compilation is notably slower on 3.3.1 than in Scala 213.11. However,
the performance seems to be better in 3.4.0, and `-Xmax-inlines` is no
longer necessary.

For now, I just add `-Xmax-inlines` and accept the compilation slowness,
so as to not break anyone using Scala 3.3.1. Eventually, as people
upgrade to 3.4.0, the problem can be expected to go away
  • Loading branch information
lihaoyi authored Feb 16, 2024
1 parent 5867ddb commit 8c6e991
Show file tree
Hide file tree
Showing 3 changed files with 239 additions and 237 deletions.
8 changes: 5 additions & 3 deletions build.sc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import com.github.lolgab.mill.mima._
val scala212 = "2.12.18"
val scala213 = "2.13.11"

val scala3 = "3.3.0"
val scala3 = "3.3.1"
val scalaNative = "0.4.14"
val acyclic = "0.3.8"

Expand All @@ -26,7 +26,7 @@ val sourcecode = "0.3.0"
val dottyCustomVersion = Option(sys.props("dottyVersion"))

val scala2JVMVersions = Seq(scala212, scala213)
val scalaVersions = scala2JVMVersions// ++ Seq(scala3) ++ dottyCustomVersion
val scalaVersions = scala2JVMVersions ++ Seq(scala3) ++ dottyCustomVersion

trait CommonPlatformModule extends ScalaModule with PlatformScalaModule{

Expand Down Expand Up @@ -97,7 +97,9 @@ trait CommonPublishModule
def scalacOptions = super.scalacOptions() ++
Agg.when(isScala3(scalaVersion())) (
"-Ximplicit-search-limit",
"200000"
"200000",
"-Xmax-inlines",
"155"
)
}
}
Expand Down
234 changes: 0 additions & 234 deletions upickle/test/src-2/upickle/TooBigTests.scala

This file was deleted.

Loading

0 comments on commit 8c6e991

Please sign in to comment.