Skip to content

Commit

Permalink
tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
lihaoyi committed Dec 11, 2023
1 parent 9ef86e3 commit ebeb340
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion scalasql/query/src/Select.scala
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ trait Select[Q, R]
new SimpleSelect(expr, exprPrefix, preserveAll, from, joins, where, groupBy0)

def qr: Queryable.Row[Q, R]
protected def joinableIsTrivial: Boolean = false
protected def joinableToSelect = this

/**
Expand Down
1 change: 0 additions & 1 deletion scalasql/query/src/WithCte.scala
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ object WithCte {
(otherFrom, WithSqlExpr.get(otherSelect))
}

override def joinableIsTrivial = true
protected override def joinableToSelect = selectToSimpleSelect()
override protected def selectToSimpleSelect(): SimpleSelect[Q, R] = {
Select.newSimpleSelect[Q, R](
Expand Down
2 changes: 0 additions & 2 deletions scalasql/src/dialects/TableOps.scala
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ class TableOps[V[_[_]]](val t: Table[V])(implicit dialect: Dialect)
new Delete.Impl(expr, filter(Table.metadata(t).vExpr(ref, dialect)), ref)
}

protected def joinableIsTrivial = true

override def joinFromExpr = {
val (ref, expr) = toFromExpr0

Expand Down

0 comments on commit ebeb340

Please sign in to comment.