fast path for flatten rec

com-lihaoyi · Dec 11, 2023 · e3834ab · e3834ab
1 parent ea1b1f7
commit e3834ab
Showing 1 changed file with 34 additions and 25 deletions.
diff --git a/scalasql/core/src/SqlStr.scala b/scalasql/core/src/SqlStr.scala
@@ -85,14 +85,8 @@ object SqlStr {
 
     def rec(self: SqlStr, topLevel: Boolean): Unit = {
       val queryParts = self.queryParts
-      val params = self.interps
-      finalExprs.addAll(self.referencedExprs)
-      var boundary = true
-      val parenthesize = !topLevel && self.isCompleteQuery
-      if (parenthesize) addFinalPart("(")
-      boundary = true
-
-      def addFinalPart(s: CharSequence) = {
+
+      def addFinalPart(boundary: Boolean, s: CharSequence) = {
         if (boundary && lastFinalPart != null) {
           lastFinalPart.append(s)
         } else {
@@ -101,26 +95,41 @@ object SqlStr {
           finalParts.addOne(lastFinalPart)
         }
       }
+      queryParts.length match{
+        case 0 => // do nothing
+        case 1 =>
+          addFinalPart(true, queryParts.head)
+          finalExprs.addAll(self.referencedExprs)
+        case _ =>
+          val params = self.interps
+          finalExprs.addAll(self.referencedExprs)
+          var boundary = true
+          val parenthesize = !topLevel && self.isCompleteQuery
+          if (parenthesize) addFinalPart(boundary, "(")
+          boundary = true
+
+
+          var i = 0
+          val length = params.length
+          while (i < length) {
+            val p = queryParts(i)
+            val a = params(i)
+            addFinalPart(boundary, p)
+            boundary = false
+            a match {
+              case si: Interp.SqlStrInterp =>
+                rec(si.s, false)
+                boundary = true
+
+              case s: Interp.TypeInterp[_] => finalInterps.addOne(s)
+            }
+            i += 1
+          }
 
-      var i = 0
-      val length = params.length
-      while (i < length) {
-        val p = queryParts(i)
-        val a = params(i)
-        addFinalPart(p)
-        boundary = false
-        a match {
-          case si: Interp.SqlStrInterp =>
-            rec(si.s, false)
-            boundary = true
-
-          case s: Interp.TypeInterp[_] => finalInterps.addOne(s)
-        }
-        i += 1
+          addFinalPart(boundary, queryParts.last)
+          if (parenthesize) addFinalPart(boundary, ")")
       }
 
-      addFinalPart(queryParts.last)
-      if (parenthesize) addFinalPart(")")
     }
 
     rec(self, true)