Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --doc, --sources, and --transitive options to publishLocal command #3512

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Sep 10, 2024

Fixes #2487

I'd like to use that locally, but keeping this PR as a draft until tests can be added, later on. (Bin compat might need to be taken into account too.)

localIvyRepo: String = null,
sources: Boolean = true,
doc: Boolean = true,
transitive: Boolean = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default for transitive should be false. Also, it should include compileModuleDeps as well, when true.

Copy link
Contributor Author

@alexarchambault alexarchambault Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that transitive should default to false. I ran into issues with it and some publishLocal tasks aggregation via T.traverse done elsewhere (because of duplicated artifacts it seems). Although starting from a blank slate, a default to true would have been nicer IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About compileModuleDeps, I'm not sure. My aim with --transitive is to allow users to use something they published straightaway. So the standard dependencies need to be published too, but the compile-only ones aren't needed. Users can resolve the published module fine without publishing the compile-only dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have publishLocal accept an option such as --doc=false to disable doc JAR generation
2 participants