-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Zinc-independent main class discovery everywhere #3436
base: main
Are you sure you want to change the base?
Conversation
Instead we use the compilation-task independent discovery of main classes.
This might also fix the issue described in #3432, since it uses a main-class discovery independent of the used compiler. @AnthonyGrod could you please verify? |
@lefou I've also tried this approach earlier but it does not work unfortunately. Discovering the main test class (which |
I see. I think the BSP spec is misleading here, as we aren't interested in any local main class but in the test runner itself. And the actual test runner isn't in the local classpath (compiler output) but the provided dependencies. Although the spec mentions, that this endpoint is also supposed to launch a custom main class. |
Instead we use the compilation-task independent discovery of main classes.