Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get CI passing on Rails main again #482

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Get CI passing on Rails main again #482

merged 3 commits into from
Feb 28, 2024

Conversation

botandrose
Copy link
Contributor

@botandrose botandrose commented Feb 26, 2024 •
edited
Loading

Fixes:

  1. Require Ruby >= 3.1
  2. Require rspec-rails >= 6.0.2
  3. Call #inspect on Relation#explain to ensure we have a string

@botandrose botandrose mentioned this pull request Feb 26, 2024
Merged
@botandrose botandrose changed the title Rails main requires Ruby 3.x now Rails main requires >= Ruby 3.1 now Feb 26, 2024
@botandrose botandrose changed the title Rails main requires >= Ruby 3.1 now Get CI passing on Rails main again Feb 26, 2024
@botandrose-machine
Relation#explain no longer returns a string, but a Relation::ExplainP…
3202d26 
…roxy. Calling #inspect will return the string, and is backwards compatible.
@botandrose
Copy link
Contributor Author

Okay, master is green again.

@parndt parndt merged commit 70cdc5e into collectiveidea:master Feb 28, 2024
59 checks passed
@parndt
Copy link
Collaborator

parndt commented Feb 28, 2024

Thank you!

@botandrose
Copy link
Contributor Author

Thank you for putting in the time to maintain this!

@botandrose botandrose deleted the fix-ci branch February 28, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parndt parndt parndt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@botandrose @parndt @botandrose-machine