Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-fix honoring of 'except' when used with 'comment_required' #425

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Re-fix honoring of 'except' when used with 'comment_required' #425

wants to merge 19 commits into from
+23 −16

Commits on Jul 9, 2018

  1. Re-fix 'except' not being honored when used with 'comment_required' 

    - collectiveidea#418
    @jeffdill2
    jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    86e3d6d View commit details
    Browse the repository at this point in the history

  2. Update tests to reflect audit_comment validation changes 

    - collectiveidea#418
    @jeffdill2
    jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    b4b9ab7 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG 

    - collectiveidea#418
    @jeffdill2
    jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    b410a85 View commit details
    Browse the repository at this point in the history

  4. Implement test to ensure except option jibes with comment_required op… 

    …tion

- collectiveidea#418
    @jeffdill2
    jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    1fa643e View commit details
    Browse the repository at this point in the history

  5. Fix typo in readme

    @KevinColemanInc @jeffdill2
    KevinColemanInc authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    928dff9 View commit details
    Browse the repository at this point in the history

  6. Remove the Gemnasium badge 

    This is a service we no longer use.
    @albus522 @jeffdill2
    albus522 authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    3172bf5 View commit details
    Browse the repository at this point in the history

  7. include 4.7.1 changelog updates [ci skip] 

    I noticed the 4.7.1 changes were missing from the Changelog.md on master. This PR adds them back.
    @stevendaniels @jeffdill2
    stevendaniels authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    e4ec6ac View commit details
    Browse the repository at this point in the history

  8. Allow nested as_user auditing (collectiveidea#450)

    @KevinColemanInc @jeffdill2
    KevinColemanInc authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    274bd5a View commit details
    Browse the repository at this point in the history

  9. allow private methods on audited condition

    @rauann @jeffdill2
    rauann authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    31200fd View commit details
    Browse the repository at this point in the history

  10. Update Changelog for collectiveidea#454

    @tbrisker @jeffdill2
    tbrisker authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    896ec43 View commit details
    Browse the repository at this point in the history

  11. improve code coverage

    @grosser @jeffdill2
    grosser authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    f49b97b View commit details
    Browse the repository at this point in the history

  12. Ensure enum changes are stored consistently

    @fatkodima @jeffdill2
    fatkodima authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    6aa3e14 View commit details
    Browse the repository at this point in the history

  13. basic rubocop checks and fixes

    @grosser @jeffdill2
    grosser authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7bf7d1c View commit details
    Browse the repository at this point in the history

  14. fix test failing and being noisy on ruby 2.5

    @grosser @jeffdill2
    grosser authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    662cc5a View commit details
    Browse the repository at this point in the history

  15. avoid exceptions in threads that print their backtrace on ruby 2.5

    @grosser @jeffdill2
    grosser authored and jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    a574453 View commit details
    Browse the repository at this point in the history

  16. Clean up the conditional logic

    @jeffdill2
    jeffdill2 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    34ee9a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Merge branch 'master' into re-fix-honoring-of-except-with-comment-req… 

    …uired
    @jeffdill2
    jeffdill2 authored Jul 10, 2018
    Configuration menu
    Copy the full SHA
    ec2d001 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Merge branch 'master' of github.com:jeffdill2/audited into re-fix-hon… 

    …oring-of-except-with-comment-required
    @jeffdill2
    jeffdill2 committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    5223c05 View commit details
    Browse the repository at this point in the history

  2. Merge branch 're-fix-honoring-of-except-with-comment-required' of git… 

    …hub.com:jeffdill2/audited into re-fix-honoring-of-except-with-comment-required
    @jeffdill2
    jeffdill2 committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    9edac04 View commit details
    Browse the repository at this point in the history