remove include dependencies #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erral
force-pushed
the
erral-remove-includeDependencies
branch
from
1b81c9d to
3bb35c4
Compare
wesleybl
reviewed
Jul 16, 2024
| @@ -7,7 +7,6 @@ | |||
| i18n_domain="plone.formwidget.masterselect"> | |||
|
|
|||
| <!-- Include our dependencies --> | |||
| <includeDependencies package="." /> | |||
There was a problem hiding this comment.
Is this causing problems for you? Generally this line is a good thing.
|
It's causing problems in Plone 6.
I tried to add Plone 6 to the testing matrix but failed. I will try to do
it and come back to the PR.
Hau idatzi du Wesley Barroso Lopes ***@***.***)
erabiltzaileak (2024 uzt. 16(a), ar. (15:49)):
… ***@***.**** commented on this pull request.
------------------------------
In src/plone/formwidget/masterselect/configure.zcml
<#45 (comment)>
:
> @@ -7,7 +7,6 @@
i18n_domain="plone.formwidget.masterselect">
<!-- Include our dependencies -->
- <includeDependencies package="." />
Is this causing problems for you? Generally this line is a good thing.
—
Reply to this email directly, view it on GitHub
<#45 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHRVK4XGJ65U736JSF53DZMUQE5AVCNFSM6AAAAABK54CVG2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBQGMYTANJYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
--
……………………………………...
Mikel Larreategi
***@***.***
+34 943 82 17 80
Azitain industrialdea 3K, E-20600 EIBAR
|
wesleybl
approved these changes
Jul 17, 2024
|
@erral maybe in setup.py we can leave only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.