Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JSON call url #38

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix JSON call url #38

merged 2 commits into from
Mar 11, 2024

Conversation

erral
Copy link
Member

@erral erral commented Oct 20, 2022

Fixes #37

@erral erral requested a review from wesleybl October 20, 2022 08:26
@wesleybl
Copy link
Member

This seems to be a difficult error to simulate. An error occurs or the URL was wrong? Can you give an example of what the URL looks like with and without your fix?

@wesleybl wesleybl closed this Feb 27, 2024
@wesleybl wesleybl reopened this Feb 27, 2024
@wesleybl
Copy link
Member

Tests on the master branch are broken.

Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleybl wesleybl merged commit db508f2 into master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON query url is wrong in subpath urls
2 participants