Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentviewer plone 5 compability #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fngaha
Copy link
Contributor

@fngaha fngaha commented Jul 5, 2021

from version 4 of documentviewer there is a browser folder

from version 4 of documentviewer there is a browser folder
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.638% when pulling 394f4a0 on fix_documentviewer_plone_5_compability into 5af7b17 on master.

@fngaha
Copy link
Contributor Author

fngaha commented Jul 5, 2021

Do not merge right away because some products (ia.docs) still use version 3.0.3 of collective.documentviewer. It will be necessary to organize oneself to pass there.

I arrived at this observation by doing an integration POC of imio.annex in iA.PST. according to the constraint of having a version lower than the 5 of collective.documentviewer, I obtained the 4.0.1 in which there is therefore now a browser folder for plone 5 compatibility.

I just saw an issue about
#30

Copy link
Contributor

@odelaere odelaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fngaha ,

Thanks for your contribution :).
Please Add your change in the CHANGES.rst.

Please pin the right version of documentviewer in version.cfg and setup.py (collective.documentviewer>???)
This way we'll avoid incompatible versions upon installing documentgenerator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants